Skip to content

Conversation

@bobot
Copy link
Contributor

@bobot bobot commented Nov 20, 2025

Stub of the C library Flint3

CHANGES:

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

A couple of questions and remarks:

Out of curiosity: I see antic, arb, and calcium are deprecated as they have been incorporated into flint. For how long do you plan to release forwarding releases of these? (I have archiving in mind) Perhaps adding a post-messages entry could encourage clients to update their dependencies? 🤔

Platform-wise it looks like conf-flint on Alpine, Centos, and FreeBSD could use a hand (...but probably as a separate PR that this one could benefit from)

There are runtest failures on arm32 and ppc64. What do you make of these?

Finally, would you consider adding an x-maintenance-intent entries?
https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md

@bobot
Copy link
Contributor Author

bobot commented Nov 25, 2025

Perhaps adding a post-messages entry could encourage clients to update their dependencies? 🤔

There is not a lot of users of this library, so next version those deprecated package will be removed. Dune perhaps already warn that they are deprecated.

Platform-wise it looks like conf-flint on Alpine, Centos, and FreeBSD could use a hand

Normally alpine should be fixed. On the other hand the package doesn't exists anymore in centos, and doesn't exists in freebsd. I don't want to forbid to install the package on this distribution since a user can install the C library manually. Perhaps there is some ci-dont-test: {os = freebsd}?

For the segfault on arm32 and ppc, I'm in the process of changing the way the binding is written. So it could disappear then. Should I do something for those platform in the mean time?

@jmid
Copy link
Member

jmid commented Nov 25, 2025

There is not a lot of users of this library, so next version those deprecated package will be removed. [,,,]

OK, thanks for sharing!

Platform-wise it looks like conf-flint on Alpine, Centos, and FreeBSD could use a hand

Normally alpine should be fixed. On the other hand the package doesn't exists anymore in centos, and doesn't exists in freebsd. I don't want to forbid to install the package on this distribution since a user can install the C library manually.

Good point!

Perhaps there is some ci-dont-test: {os = freebsd}?

We cannot prevent the CI run but we can silence the CI-error on FreeBSD: 🤷

x-ci-accept-failures: ["freebsd-14.3"]

For the segfault on arm32 and ppc, I'm in the process of changing the way the binding is written. So it could disappear then. Should I do something for those platform in the mean time?

If the packages work reasonably on arm32 and ppc64 except for test suite corner cases, we could just disable runtest on those platforms:

    "@runtest" {with-test & arch != "arm32" & arch != "ppc64"}

Alternatively, we could just disable the packages entirely on the platforms to prevent potential users from chasing segfault ghosts: 👻

available: arch != "arm32" & arch != "ppc64"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants